Hide backup and scan activities from sites without backup access by crazytonyli · Pull Request #23218 · wordpress-mobile/WordPress-Android

crazytonyli · 2026-08-14T08:25:44Z

Replicate wordpress-mobile/WordPress-iOS#25894

…ccess WordPress.com backs up Simple sites internally and writes those events to the activity log regardless of plan, so the activity endpoint returns backup ("rewind") and scan activities even for sites whose plan does not include those products. The web Activity Log excludes them by sending not_group[]=rewind&not_group[]=scan when the site lacks the backups-self-serve feature, but the apps never did, causing the mobile Activity Log to show "Backup and scan complete" entries that the web hides. This mirrors the web behavior (getActivityLogHiddenGroups in wp-calypso): a new GetActivityLogHiddenGroupsUseCase decides which groups to hide based on the backups-self-serve plan feature, falling back to purchased Jetpack backup/scan products for self-hosted sites, and the activity log fetch passes them through a new notGroups field on FetchActivityLogPayload so the server filters them out. The activity type filter picker removes the hidden groups from its list so they cannot be selected, and the Backup screen keeps showing rewind events since that is its purpose.

dangermattic · 2026-08-14T08:26:14Z

	1 Warning
⚠️	This PR is assigned to the milestone 27.1. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

wpmobilebot · 2026-08-14T08:36:15Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr23218-d15e0c7
	Build Number	`1498`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`d15e0c7`
	Installation URL	6okbobrl9ktto

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-08-14T08:36:15Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr23218-d15e0c7
	Build Number	`1498`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`d15e0c7`
	Installation URL	749avgdda3on0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-08-14T08:39:40Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

nbradbury · 2026-08-17T12:23:58Z

@crazytonyli Overall this looks good, but Claude found a few issues, and checks are failing.

review-pr-23218-issues-2026-08-17.pdf

crazytonyli · 2026-08-18T01:59:47Z

@nbradbury Are the two medium issues acceptable or blockers, in the context of this codebase? The first issue about standalone Jetpack Backup plugin sounds like an existing issue. I'm not sure how much real impact the second issue (querying from the main thread) has.

nbradbury · 2026-08-18T11:38:38Z

Are the two medium issues acceptable or blockers, in the context of this codebase?

I don't consider either blockers, but the CI failure is a blocker.

nbradbury · 2026-08-18T16:33:26Z

@crazytonyli I'll go ahead and approve this so you can merge it once the CI issue is resolved.

nbradbury

crazytonyli · 2026-08-18T23:45:32Z

@nbradbury Thanks for the review!

codecov · 2026-08-18T23:58:23Z

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.92%. Comparing base (52d78ca) to head (d15e0c7).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...i/activitylog/GetActivityLogHiddenGroupsUseCase.kt	88.88%	0 Missing and 1 partial ⚠️
...ylog/list/filter/ActivityLogTypeFilterViewModel.kt	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #23218   +/-   ##
=======================================
  Coverage   37.91%   37.92%           
=======================================
  Files        2333     2334    +1     
  Lines      126964   126984   +20     
  Branches    17583    17589    +6     
=======================================
+ Hits        48144    48162   +18     
  Misses      74888    74888           
- Partials     3932     3934    +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

crazytonyli added this to the 27.1 milestone Aug 14, 2026

crazytonyli requested review from adalpari and nbradbury August 14, 2026 08:25

crazytonyli added the Activity Log label Aug 14, 2026

nbradbury approved these changes Aug 18, 2026

View reviewed changes

Suppress detekt LargeClass warning in ActivityLogRestClientTest

051debd

crazytonyli enabled auto-merge (squash) August 18, 2026 23:45

Merge branch 'trunk' into bugfix/cmm-2130-filter-activity-logs

d15e0c7

crazytonyli merged commit 419039b into trunk Aug 19, 2026
21 of 23 checks passed

crazytonyli deleted the bugfix/cmm-2130-filter-activity-logs branch August 19, 2026 00:40

Navigation Menu

Uh oh!

Hide backup and scan activities from sites without backup access - #23218

Hide backup and scan activities from sites without backup access#23218
crazytonyli merged 3 commits into
trunkfrom
bugfix/cmm-2130-filter-activity-logs

crazytonyli commented Aug 14, 2026

Uh oh!

dangermattic commented Aug 14, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 14, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 14, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Aug 14, 2026

Uh oh!

nbradbury commented Aug 17, 2026

Uh oh!

crazytonyli commented Aug 18, 2026

Uh oh!

nbradbury commented Aug 18, 2026

Uh oh!

nbradbury commented Aug 18, 2026

Uh oh!

nbradbury left a comment

Uh oh!

crazytonyli commented Aug 18, 2026

Uh oh!

codecov Bot commented Aug 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

crazytonyli commented Aug 14, 2026

Uh oh!

dangermattic commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Aug 14, 2026

🤖 Build Failure Analysis

Uh oh!

nbradbury commented Aug 17, 2026

Uh oh!

crazytonyli commented Aug 18, 2026

Uh oh!

nbradbury commented Aug 18, 2026

Uh oh!

nbradbury commented Aug 18, 2026

Uh oh!

nbradbury left a comment

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Aug 18, 2026

Uh oh!

codecov Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dangermattic commented Aug 14, 2026 •

edited

Loading

wpmobilebot commented Aug 14, 2026 •

edited

Loading

wpmobilebot commented Aug 14, 2026 •

edited

Loading

codecov Bot commented Aug 18, 2026 •

edited

Loading